From 1ad79001485d2419f3ff2cd25da4088d5d2a36bb Mon Sep 17 00:00:00 2001
From: Robert Kaussow <mail@geeklabor.de>
Date: Wed, 12 Feb 2020 19:36:08 +0100
Subject: [PATCH] improve bash script

---
 templates/usr/local/bin/scan2mail.j2 | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/templates/usr/local/bin/scan2mail.j2 b/templates/usr/local/bin/scan2mail.j2
index 7caaaac..d6a9f10 100644
--- a/templates/usr/local/bin/scan2mail.j2
+++ b/templates/usr/local/bin/scan2mail.j2
@@ -1,14 +1,16 @@
 #jinja2: lstrip_blocks: True
-#!/bin/bash
+#!/usr/bin/env bash
 {{ ansible_managed | comment }}
 
+set -eo pipefail
+
 FILEPATH=$1
 FILENAME=$2
 
 FROM_ADDR="{{ scan2mail_from_address }}"
-TO_ADDRESS="`basename \"$FILEPATH\"`@{{ scan2mail_mail_domain }}"
-ATTACHMENT="$1/$2"
+TO_ADDRESS=$(basename "${FILEPATH}")@{{ scan2mail_mail_domain }}
+ATTACHMENT="${FILEPATH}/${FILENAME}"
 
 sleep 10
 
-echo "{{ scan2mail_message | default('') }}" | mail -s "{{ scan2mail_subject }}" -a "From: ${FROM_ADDR}" -A ${ATTACHMENT} ${TO_ADDRESS}
+echo "{{ scan2mail_message | default('') }}" | mail -s "{{ scan2mail_subject }}" -a "From: ${FROM_ADDR}" -A "${ATTACHMENT}" "${TO_ADDRESS}"