ansible-later/ansiblelater/rules/taskfiles.py

42 lines
1.4 KiB
Python
Raw Permalink Normal View History

2019-04-04 14:06:18 +00:00
"""Checks related to ansible task files."""
2018-12-19 10:19:07 +00:00
2019-04-04 14:06:18 +00:00
import re
2018-12-19 10:19:07 +00:00
from collections import defaultdict
from ansiblelater.command.candidates import Error
from ansiblelater.command.candidates import Result
from ansiblelater.utils.rulehelper import get_normalized_tasks
2018-12-19 10:19:07 +00:00
from ansiblelater.utils.rulehelper import get_normalized_yaml
def check_line_between_tasks(candidate, settings):
options = defaultdict(dict)
options.update(remove_empty=False)
options.update(remove_markers=False)
lines, line_errors = get_normalized_yaml(candidate, settings, options)
tasks, task_errors = get_normalized_tasks(candidate, settings)
2018-12-19 10:19:07 +00:00
description = "missing task separation (required: 1 empty line)"
task_regex = re.compile(r"-\sname:(.*)")
2018-12-19 10:19:07 +00:00
prevline = "#file_start_marker"
allowed_prevline = ["---", "tasks:", "pre_tasks:", "post_tasks:", "block:"]
errors = task_errors + line_errors
2018-12-19 10:19:07 +00:00
if not errors:
for i, line in lines:
2018-12-19 10:19:07 +00:00
match = task_regex.search(line)
if match and prevline:
name = match.group(1).strip()
if not any(task.get("name") == name for task in tasks):
continue
2018-12-19 10:19:07 +00:00
if not any(item in prevline for item in allowed_prevline):
errors.append(Error(i, description))
2018-12-19 10:19:07 +00:00
prevline = line.strip()
return Result(candidate.path, errors)