From 6f2a06357fd17d2695c272e2570d774bee2c8a78 Mon Sep 17 00:00:00 2001 From: Robert Kaussow Date: Sun, 31 Jan 2021 12:35:57 +0100 Subject: [PATCH] rename and fix rule CheckFilePermissionMissing --- ...ngFilePermission.py => CheckFilePermissionMissing.py} | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) rename ansiblelater/rules/{CheckMissingFilePermission.py => CheckFilePermissionMissing.py} (93%) diff --git a/ansiblelater/rules/CheckMissingFilePermission.py b/ansiblelater/rules/CheckFilePermissionMissing.py similarity index 93% rename from ansiblelater/rules/CheckMissingFilePermission.py rename to ansiblelater/rules/CheckFilePermissionMissing.py index 000c497..e50a4ec 100644 --- a/ansiblelater/rules/CheckMissingFilePermission.py +++ b/ansiblelater/rules/CheckFilePermissionMissing.py @@ -20,7 +20,7 @@ from ansiblelater.standard import StandardBase -class CheckMissingFilePermission(StandardBase): +class CheckFilePermissionMissing(StandardBase): sid = "ANSIBLE0018" description = "File permissions unset or incorrect" @@ -55,7 +55,7 @@ class CheckMissingFilePermission(StandardBase): if not errors: for task in tasks: - if not self._check_mode(task): + if self._check_mode(task): errors.append( self.Error( task["__line__"], @@ -82,7 +82,7 @@ class CheckMissingFilePermission(StandardBase): create = task["action"].get("create", self._create_modules[module]) return create and mode is None - # A file that doesn"t exist cannot have a mode + # A file that doesn't exist cannot have a mode if task["action"].get("state", None) == "absent": return False @@ -95,8 +95,7 @@ class CheckMissingFilePermission(StandardBase): return False # The file module does not create anything when state==file (default) - if module == "file" and \ - task["action"].get("state", "file") == "file": + if module == "file" and task["action"].get("state", "file") == "file": return False # replace module is the only one that has a valid default preserve