diff --git a/ansiblelater/candidate.py b/ansiblelater/candidate.py index 78adebf..23376aa 100644 --- a/ansiblelater/candidate.py +++ b/ansiblelater/candidate.py @@ -200,7 +200,7 @@ class Candidate(object): or filename.endswith(".py") ): return Code(filename, settings, standards) - if "inventory" == basename or "hosts" == basename or parentdir in ["inventories"]: + if basename == "inventory" or basename == "hosts" or parentdir in ["inventories"]: return Inventory(filename, settings, standards) if "rolesfile" in basename or "requirements" in basename: return Rolesfile(filename, settings, standards) diff --git a/ansiblelater/rules/CheckShellInsteadCommand.py b/ansiblelater/rules/CheckShellInsteadCommand.py index 5b29de0..ec82305 100644 --- a/ansiblelater/rules/CheckShellInsteadCommand.py +++ b/ansiblelater/rules/CheckShellInsteadCommand.py @@ -28,7 +28,7 @@ class CheckShellInsteadCommand(StandardBase): cmd = " ".join(task["action"].get("__ansible_arguments__", [])) unjinja = re.sub(r"\{\{[^\}]*\}\}", "JINJA_VAR", cmd) - if not any([ch in unjinja for ch in "&|<>;$\n*[]{}?"]): + if not any(ch in unjinja for ch in "&|<>;$\n*[]{}?"): errors.append(self.Error(task["__line__"], self.helptext)) return self.Result(candidate.path, errors) diff --git a/ansiblelater/utils/__init__.py b/ansiblelater/utils/__init__.py index 37838fd..2a71dec 100644 --- a/ansiblelater/utils/__init__.py +++ b/ansiblelater/utils/__init__.py @@ -63,7 +63,7 @@ def lines_ranges(lines_spec): def is_line_in_ranges(line, ranges): - return not ranges or any([line in r for r in ranges]) + return not ranges or any(line in r for r in ranges) def safe_load(string):