From e05cad6de7686800a43b2baa32799970b1da1922 Mon Sep 17 00:00:00 2001 From: Robert Kaussow Date: Mon, 15 Apr 2019 12:26:58 +0200 Subject: [PATCH] rename ansible_review_min_version to ansible_later_min_version --- CHANGELOG.md | 1 + ansiblelater/command/base.py | 6 +++--- ansiblelater/data/standards.py | 2 +- ansiblelater/tests/config/standards.py | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4bd7d0..7da0e58 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ with old releases. - Switch configuration files to YAML - Enable multi location configuration files [#14](https://github.com/xoxys/ansible-later/issues/14) - ID's used in standards have to be unique (or not set) + - `ansible_review_min_version` was renamed to `ansible_later_min_version` - FEATURE - Add optional JSON logging [#13](https://github.com/xoxys/ansible-later/issues/13) diff --git a/ansiblelater/command/base.py b/ansiblelater/command/base.py index 296cd33..bc3bffa 100644 --- a/ansiblelater/command/base.py +++ b/ansiblelater/command/base.py @@ -41,13 +41,13 @@ def get_standards(filepath): "Please upgrade ansible." % (standards.ansible_min_version, ansible.__version__)) - if getattr(standards, "ansible_review_min_version", None) and \ - LooseVersion(standards.ansible_review_min_version) > LooseVersion( + if getattr(standards, "ansible_later_min_version", None) and \ + LooseVersion(standards.ansible_later_min_version) > LooseVersion( utils.get_property("__version__")): utils.sysexit_with_message( "Standards require ansible-later version %s (current version %s). " "Please upgrade ansible-later." % - (standards.ansible_review_min_version, utils.get_property("__version__"))) + (standards.ansible_later_min_version, utils.get_property("__version__"))) normalized_std = (list(toolz.remove(lambda x: x.id == "", standards.standards))) unique_std = len(list(toolz.unique(normalized_std, key=lambda x: x.id))) diff --git a/ansiblelater/data/standards.py b/ansiblelater/data/standards.py index 31437fa..9035114 100644 --- a/ansiblelater/data/standards.py +++ b/ansiblelater/data/standards.py @@ -226,7 +226,7 @@ use_yaml_rather_than_key_value = Standard(dict( ansible_min_version = "2.5" -ansible_review_min_version = "0.1.0" +ansible_later_min_version = "0.2.0" standards = [ diff --git a/ansiblelater/tests/config/standards.py b/ansiblelater/tests/config/standards.py index 711466d..455a015 100644 --- a/ansiblelater/tests/config/standards.py +++ b/ansiblelater/tests/config/standards.py @@ -197,7 +197,7 @@ use_yaml_rather_than_key_value = Standard(dict( ansible_min_version = '2.1' -ansible_review_min_version = '0.1.0' +ansible_later_min_version = '0.1.0' standards = [