github/corenetworks
0
0
Fork 0
mirror of https://github.com/thegeeklab/corenetworks.git synced 2024-11-25 06:20:39 +00:00
Code Issues Releases Activity

add a workaround to prevent CNAME creation if a record with the same name already exists

Browse Source
This commit is contained in:
Robert Kaussow 2020-05-11 18:42:57 +02:00
parent 0edfc084d7
commit 6db805d507
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -2,3 +2,4 @@
* make `ttl` mandatory for add function * make `ttl` mandatory for add function
* BUGFIX * BUGFIX
* update (delete + create) records with different `ttl` to prevent duplicate entries * update (delete + create) records with different `ttl` to prevent duplicate entries
* add a workaround to prevent CNAME creation if a record with the same name already exists

15
corenetworks/client.py
View File

@ -205,10 +205,23 @@ class CoreNetworks():
schema["required"] = ["name", "type", "data", "ttl"] schema["required"] = ["name", "type", "data", "ttl"]
self.__validate(params, schema) self.__validate(params, schema)
if params["type"] == "CNAME":
if params["name"] == "@":
raise CorenetworksError("CNAME records are not allowed for the zone itself.")
records = self.records(zone, params={"name": params["name"]})
for r in records:
raise CorenetworksError(
"A record with the same name already exist ({name}). "
"CNAME records cannot use the same name with other records.".format(
name=r["name"]
)
)
curr = copy.deepcopy(params) curr = copy.deepcopy(params)
curr.pop("ttl") curr.pop("ttl")
records = self.records(zone, curr) records = self.records(zone, curr)
if len(records) > 1: if len(records) > 1:
raise CorenetworksError( raise CorenetworksError(
"More than one record already exists for the given attributes. " "More than one record already exists for the given attributes. "