github/corenetworks
0
0
Fork 0
mirror of https://github.com/thegeeklab/corenetworks.git synced 2024-11-24 20:10:40 +00:00
Code Issues Releases Activity

ensure CNAME records could not mixed with other types using the same name

Browse Source
This commit is contained in:
Robert Kaussow 2020-05-11 22:23:13 +02:00
parent e3dce0340f
commit a332423c45
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGELOG.md
View File

@ -1,6 +1,2 @@
* ENHANCEMENT
* make `ttl` mandatory for add function
* add `requests` to requirements
* BUGFIX * BUGFIX
* update (delete + create) records with different `ttl` to prevent duplicate entries * extend the workaround to ensure CNAME records could not mixed with other types using the same name
* add a workaround to prevent CNAME creation if a record with the same name already exists

5
corenetworks/client.py
View File

@ -209,8 +209,9 @@ class CoreNetworks():
if params["name"] == "@": if params["name"] == "@":
raise CorenetworksError("CNAME records are not allowed for the zone itself.") raise CorenetworksError("CNAME records are not allowed for the zone itself.")
records = self.records(zone, params={"name": params["name"]}) records = self.records(zone, params={"name": params["name"]})
for r in records: for r in records:
if params["type"] == "CNAME" or r["type"] == "CNAME":
raise CorenetworksError( raise CorenetworksError(
"A record with the same name already exist ({name}). " "A record with the same name already exist ({name}). "
"CNAME records cannot use the same name with other records.".format( "CNAME records cannot use the same name with other records.".format(