From 47f3b4bb08ae027e3d791f7895d220c66a98b042 Mon Sep 17 00:00:00 2001 From: shimun Date: Mon, 5 Nov 2018 19:43:29 +0100 Subject: [PATCH] prevent index out of bounds --- docker.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docker.go b/docker.go index 8cea3fc..c3c7332 100644 --- a/docker.go +++ b/docker.go @@ -144,7 +144,7 @@ func (p Plugin) Exec() error { trace(cmd) err := cmd.Run() - if err != nil && cmd.Args[1] == "pull" { + if err != nil && isCommandPull(cmd.Args) { fmt.Printf("Could not pull cache-from image %s. Ignoring...\n", cmd.Args[2]) } else if err != nil { return err @@ -170,6 +170,11 @@ func commandLogin(login Login) *exec.Cmd { ) } +// helper to check if args match "docker pull " +func isCommandPull(args []string) bool { + return len(args) > 2 && args[1] == "pull" +} + func commandPull(repo string) *exec.Cmd { return exec.Command(dockerExe, "pull", repo) }