From afe8297ea7b3097ec01a161fb450a5bac2f4d8f9 Mon Sep 17 00:00:00 2001 From: Robert Kaussow Date: Sun, 29 May 2022 21:47:41 +0200 Subject: [PATCH] refactor: add plugin flags to category --- cmd/drone-github-comment/config.go | 8 +++++++- cmd/drone-github-comment/main.go | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/cmd/drone-github-comment/config.go b/cmd/drone-github-comment/config.go index 35f4c62..4c4f38c 100644 --- a/cmd/drone-github-comment/config.go +++ b/cmd/drone-github-comment/config.go @@ -6,13 +6,14 @@ import ( ) // settingsFlags has the cli.Flags for the plugin.Settings. -func settingsFlags(settings *plugin.Settings) []cli.Flag { +func settingsFlags(settings *plugin.Settings, category string) []cli.Flag { return []cli.Flag{ &cli.StringFlag{ Name: "api-key", EnvVars: []string{"PLUGIN_API_KEY", "GITHUB_COMMENT_API_KEY"}, Usage: "sets api key to access github api", Destination: &settings.APIKey, + Category: category, }, &cli.StringFlag{ Name: "base-url", @@ -20,24 +21,28 @@ func settingsFlags(settings *plugin.Settings) []cli.Flag { Usage: "sets api url; need to be changed for gh enterprise", Value: "https://api.github.com/", Destination: &settings.BaseURL, + Category: category, }, &cli.StringFlag{ Name: "key", EnvVars: []string{"PLUGIN_KEY", "GITHUB_COMMENT_KEY"}, Usage: "sets unique key to assign to comment", Destination: &settings.Key, + Category: category, }, &cli.StringFlag{ Name: "message", EnvVars: []string{"PLUGIN_MESSAGE", "GITHUB_COMMENT_MESSAGE"}, Usage: "sets file or string with comment message", Destination: &settings.Message, + Category: category, }, &cli.BoolFlag{ Name: "update", EnvVars: []string{"PLUGIN_UPDATE", "GITHUB_COMMENT_UPDATE"}, Usage: "enables update of an existing comment that matches the key", Destination: &settings.Update, + Category: category, }, &cli.BoolFlag{ Name: "skip-missing", @@ -45,6 +50,7 @@ func settingsFlags(settings *plugin.Settings) []cli.Flag { Usage: "skips comment creation if the given message file does not exist", Value: false, Destination: &settings.SkipMissing, + Category: category, }, } } diff --git a/cmd/drone-github-comment/main.go b/cmd/drone-github-comment/main.go index 48dda3b..bb384f8 100644 --- a/cmd/drone-github-comment/main.go +++ b/cmd/drone-github-comment/main.go @@ -31,7 +31,7 @@ func main() { Name: "drone-github-comment", Usage: "handle comments to github issues or pull requests", Version: BuildVersion, - Flags: append(settingsFlags(settings), urfave.Flags()...), + Flags: append(settingsFlags(settings, urfave.FlagsPluginCategory), urfave.Flags()...), Action: run(settings), }