From a338c245d7d71d0a863636fdbdb6439317e3cc9d Mon Sep 17 00:00:00 2001 From: Brad Rydzewski Date: Mon, 10 Jun 2019 15:04:37 -0700 Subject: [PATCH] handle duplicate names in conversion --- yaml/converter/legacy/internal/config.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/yaml/converter/legacy/internal/config.go b/yaml/converter/legacy/internal/config.go index f3d90f4..0b6c774 100644 --- a/yaml/converter/legacy/internal/config.go +++ b/yaml/converter/legacy/internal/config.go @@ -86,6 +86,14 @@ func Convert(d []byte) ([]byte, error) { ) } + names := map[string]struct{}{} + for i, step := range pipeline.Steps { + if _, ok := names[step.Name]; ok { + step.Name = fmt.Sprintf("%s_%d", step.Name, i) + } + names[step.Name] = struct{}{} + } + pipeline.Volumes = toVolumes(from) pipeline.Trigger.Branch.Include = from.Branches.Include pipeline.Trigger.Branch.Exclude = from.Branches.Exclude