diff --git a/.lighthouserc.yml b/.lighthouserc.yml index 3905309..978d57e 100644 --- a/.lighthouserc.yml +++ b/.lighthouserc.yml @@ -33,6 +33,8 @@ ci: image-size-responsive: off render-blocking-resources: off largest-contentful-paint: off + total-byte-weight: warn + identical-links-same-purpose: warn tap-targets: warn unsized-images: warn # FIXME: https://github.com/GoogleChrome/lighthouse/issues/11460 diff --git a/.woodpecker/test.yml b/.woodpecker/test.yml index beb5780..f6c6986 100644 --- a/.woodpecker/test.yml +++ b/.woodpecker/test.yml @@ -44,7 +44,7 @@ steps: - lychee --no-progress --format detailed exampleSite/content/ README.md - name: page-validation - image: quay.io/thegeeklab/lhci:0.12 + image: quay.io/thegeeklab/lhci:0.13 group: test commands: - lhci autorun diff --git a/exampleSite/content/en/usage/getting-started.md b/exampleSite/content/en/usage/getting-started.md index c5df602..f7e92d0 100644 --- a/exampleSite/content/en/usage/getting-started.md +++ b/exampleSite/content/en/usage/getting-started.md @@ -44,7 +44,7 @@ To prepare your new site environment just a few steps are required: 3. Install the Geekdoc theme from a [release bundle](#option-1-download-pre-build-release-bundle) (recommended) or from [Git branch](#option-2-clone-the-github-repository). -4. Create the minimal required Hugo configuration `config.toml`. For all configuration options take a look at the [configuration](/usage/configuration/) page. +4. Create the minimal required Hugo configuration `config.toml`. For all configuration options take a look at the [configuration page](/usage/configuration/). ```toml baseURL = "http://localhost" @@ -147,7 +147,7 @@ clean: rm -rf $(BASEDIR)/public ``` -This Makefile can be used in your `netlify.toml`, take a look at the Netlify [example](https://docs.netlify.com/configure-builds/file-based-configuration/#sample-netlify-toml-file) for more information: +This Makefile can be used in your `netlify.toml`, take a look at the [Netlify example](https://docs.netlify.com/configure-builds/file-based-configuration/#sample-netlify-toml-file) for more information: ```toml [build] @@ -193,7 +193,7 @@ Using `hugo --minify` without further configuration or using other minify tools After some testing we decided to not spend effort to fix this issue for now as the benefit is very low. There are some parts of the theme where spaces between HTML elements matters but were stripped by minify tools. Some of these issues are related to [gohugoio/hugo#6892](https://github.com/gohugoio/hugo/issues/6892). While recommendation like "don't depend on whitespace in your layout" sounds reasonable, it seems to be not that straight forward especially for something like embedded icons into the text flow. -If you still want to use Hugo's minify flag you should at least exclude HTML file in your site [configuration](https://gohugo.io/getting-started/configuration/#configure-minify): +If you still want to use Hugo's minify flag you should at least exclude HTML files in your site configuration as described in the [Hugo documentation](https://gohugo.io/getting-started/configuration/#configure-minify): ```toml [minify] diff --git a/src/sass/_base.scss b/src/sass/_base.scss index 395bd4b..66b0e33 100644 --- a/src/sass/_base.scss +++ b/src/sass/_base.scss @@ -547,8 +547,12 @@ svg.gdoc-icon { background: var(--footer-background); color: var(--footer-font-color); - .fake-link:hover { - background-image: linear-gradient(var(--footer-link-color), var(--footer-link-color)); + .fake-link { + text-decoration: none; + + &:hover { + background-image: linear-gradient(var(--footer-link-color), var(--footer-link-color)); + } } &__item { @@ -560,6 +564,7 @@ svg.gdoc-icon { } &__link { + text-decoration: underline; color: var(--footer-link-color); &:visited { @@ -734,6 +739,7 @@ svg.gdoc-icon { &__link, &__link:visited { + text-decoration: underline; color: var(--link-color); } @@ -773,6 +779,7 @@ svg.gdoc-icon { a, a:visited { + text-decoration: none !important; color: var(--link-color); } } diff --git a/src/sass/_markdown.scss b/src/sass/_markdown.scss index 8b2552e..1a64017 100644 --- a/src/sass/_markdown.scss +++ b/src/sass/_markdown.scss @@ -31,7 +31,7 @@ a, &__link { - text-decoration: none; + text-decoration: underline; border-bottom: $border-1 solid transparent; line-height: normal;