From 50d70f71b58cd05d4864203fdca25f709ad378c6 Mon Sep 17 00:00:00 2001 From: Thomas Boerger Date: Sun, 21 Feb 2016 10:38:53 +0100 Subject: [PATCH 1/6] Added all task as first task to makefile --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 35885ba..fb8dc5f 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -.PHONY: clean deps fmt vet test docker +.PHONY: all clean deps fmt vet test docker EXECUTABLE ?= drone-github-release IMAGE ?= plugins/$(EXECUTABLE) @@ -7,6 +7,8 @@ CI_BUILD_NUMBER ?= 0 LDFLAGS = -X "main.buildDate=$(shell date -u '+%Y-%m-%d %H:%M:%S %Z')" PACKAGES = $(shell go list ./... | grep -v /vendor/) +all: deps build test + clean: go clean -i ./... From 7b5eb81d0c1eab0a9029431c3a873ee3e8b29132 Mon Sep 17 00:00:00 2001 From: Thomas Boerger Date: Sun, 21 Feb 2016 10:43:08 +0100 Subject: [PATCH 2/6] Removed unused CI_BUILD_NUMBER from makefile --- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index fb8dc5f..ffd60b2 100644 --- a/Makefile +++ b/Makefile @@ -2,7 +2,6 @@ EXECUTABLE ?= drone-github-release IMAGE ?= plugins/$(EXECUTABLE) -CI_BUILD_NUMBER ?= 0 LDFLAGS = -X "main.buildDate=$(shell date -u '+%Y-%m-%d %H:%M:%S %Z')" PACKAGES = $(shell go list ./... | grep -v /vendor/) From 2d8d03bc22ce81487e51c22b9dd2ada573fb9cfa Mon Sep 17 00:00:00 2001 From: Thomas Boerger Date: Sun, 21 Feb 2016 11:06:40 +0100 Subject: [PATCH 3/6] Make the builds reproducable based on commit sha --- Makefile | 3 ++- main.go | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index ffd60b2..0eab019 100644 --- a/Makefile +++ b/Makefile @@ -2,8 +2,9 @@ EXECUTABLE ?= drone-github-release IMAGE ?= plugins/$(EXECUTABLE) +COMMIT ?= $(shell git rev-parse --short HEAD) -LDFLAGS = -X "main.buildDate=$(shell date -u '+%Y-%m-%d %H:%M:%S %Z')" +LDFLAGS = -X "main.buildCommit=$(COMMIT)" PACKAGES = $(shell go list ./... | grep -v /vendor/) all: deps build test diff --git a/main.go b/main.go index f7f1336..c5e8522 100644 --- a/main.go +++ b/main.go @@ -15,11 +15,11 @@ import ( ) var ( - buildDate string + buildCommit string ) func main() { - fmt.Printf("Drone GitHub Release Plugin built at %s\n", buildDate) + fmt.Printf("Drone GitHub Release Plugin built from %s\n", buildCommit) workspace := drone.Workspace{} repo := drone.Repo{} From c472a70babb21d5d51d2b331c96ed418edf1367b Mon Sep 17 00:00:00 2001 From: Thomas Boerger Date: Sun, 21 Feb 2016 11:20:00 +0100 Subject: [PATCH 4/6] Updated maintainers file, added names and athieriot --- MAINTAINERS | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a63ad47..0ecaf19 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4,6 +4,8 @@ email = "brad@drone.io" login = "bradrydzewski" [people.Bugagazavr] + name = "Kirill" + email = "" login = "Bugagazavr" [people.donny-dont] name = "Don Olmstead" @@ -23,9 +25,22 @@ login = "nlf" [people.tboerger] name = "Thomas Boerger" - email = "" + email = "thomas@webhippie.de" login = "tboerger" + [people.athieriot] + name = "Aurélien Thieriot" + email = "a.thieriot@gmail.com" + login = "athieriot" [org] [org.core] - people = ["bradrydzewski", "Bugagazavr", "donny-dont", "jackspirou", "msteinert", "nlf", "tboerger"] + people = [ + "bradrydzewski", + "Bugagazavr", + "donny-dont", + "jackspirou", + "msteinert", + "nlf", + "tboerger", + "athieriot" + ] From a3d90a64a5a78d2310cd63dfeea806c427d085b5 Mon Sep 17 00:00:00 2001 From: Thomas Boerger Date: Sun, 21 Feb 2016 11:38:17 +0100 Subject: [PATCH 5/6] Updated gitignore to respect also coverage.out --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 5dc0f42..a990248 100644 --- a/.gitignore +++ b/.gitignore @@ -23,4 +23,5 @@ _testmain.go *.test *.prof +coverage.out drone-github-release From ee7be061e68042307e6c78dc73b0f75a61743308 Mon Sep 17 00:00:00 2001 From: Thomas Boerger Date: Sun, 21 Feb 2016 12:30:25 +0100 Subject: [PATCH 6/6] Reference to DOCS.md from README.md for usage information --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2466d7e..56ff55f 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![Coverage Status](https://aircover.co/badges/drone-plugins/drone-github-release/coverage.svg)](https://aircover.co/drone-plugins/drone-github-release) [![](https://badge.imagelayers.io/plugins/drone-github-release:latest.svg)](https://imagelayers.io/?images=plugins/drone-github-release:latest 'Get your own badge on imagelayers.io') -Drone plugin to publish files and artifacts to GitHub Release +Drone plugin to publish files and artifacts to GitHub Release. For the usage information and a listing of the available options please take a look at [the docs](DOCS.md). ## Binary