fix: use try to set default for server list (#7)

Reviewed-on: #7
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Co-committed-by: Robert Kaussow <mail@thegeeklab.de>

.woodpecker/test.yml

@@ -16,9 +16,9 @@ steps:
     commands:
       - tflint --color
 
-  - name: terraform
-    image: docker.io/jmccann/drone-terraform:8
+  - name: tofu
+    image: quay.io/thegeeklab/wp-opentofu
     settings:
-      actions:
+      action:
         - validate
-      tf_version: 1.5.0
+      tofu_version: 1.6.1

main.tf

@@ -1,8 +1,26 @@
+locals {
+  ipv4_addresses = {
+    for server_key, server in var.server : server.name => flatten([
+      for k, v in try(proxmox_virtual_environment_vm.server[server.name].ipv4_addresses, []) :
+      v if length(regexall(try(server.netif_filter, var.server_netif_filter), proxmox_virtual_environment_vm.server[server.name].network_interface_names[k])) > 0
+    ])
+  }
+}
+
+locals {
+  ipv6_addresses = {
+    for server_key, server in var.server : server.name => flatten([
+      for k, v in try(proxmox_virtual_environment_vm.server[server.name].ipv6_addresses, []) :
+      v if length(regexall(try(server.netif_filter, var.server_netif_filter), proxmox_virtual_environment_vm.server[server.name].network_interface_names[k])) > 0
+    ])
+  }
+}
+
 resource "proxmox_virtual_environment_vm" "server" {
   for_each = { for row in var.server : row.name => row }
 
   name        = "${each.value.name}.${try(each.value.dns_zone, var.server_dns_zone)}"
-  description = try(each.value.description, " ")
+  description = try(each.value.description, null)
   tags = concat(
     [
       "provisioner_terraform",
@@ -95,12 +113,7 @@ resource "restapi_object" "ucs_server" {
     "position" : var.ucs_zones[try(each.value.dns_zone, var.server_dns_zone)],
     "properties" : {
       "name" : each.value.name,
-      "a" : concat(
-        [
-          for k, v in flatten(coalesce(proxmox_virtual_environment_vm.server[each.value.name].ipv4_addresses, [])) :
-          v if k != try(index(proxmox_virtual_environment_vm.server[each.value.name].network_interface_names, "lo"), -1)
-        ],
-      ),
+      "a" : concat(local.ipv4_addresses[each.key]),
     }
   })
 }

outputs.tf

@@ -1,5 +1,8 @@
 output "output" {
   value = {
-    for server_key, server in proxmox_virtual_environment_vm.server : server_key => server
+    for server_key, server in proxmox_virtual_environment_vm.server : server_key => merge(
+      server,
+      { ipv4_addresses = local.ipv4_addresses[server_key] },
+    )
   }
 }

variables.tf

@@ -43,3 +43,8 @@ variable "server_guest_agent" {
   type    = bool
   default = false
 }
+
+variable "server_netif_filter" {
+  type    = string
+  default = "^(eth|ens|enp).+"
+}

versions.tf

@@ -1,13 +1,13 @@
 terraform {
   required_providers {
     cloudflare = {
-      source = "cloudflare/cloudflare"
+      source = "registry.opentofu.org/cloudflare/cloudflare"
     }
     proxmox = {
-      source = "bpg/proxmox"
+      source = "registry.opentofu.org/bpg/proxmox"
     }
     restapi = {
-      source = "mastercard/restapi"
+      source = "registry.opentofu.org/thegeeklab/restapi"
     }
   }
 }