mirror of
https://github.com/thegeeklab/ansible-later.git
synced 2024-11-13 00:30:39 +00:00
30 lines
1.1 KiB
Python
30 lines
1.1 KiB
Python
|
from ansiblelater.standard import StandardBase
|
||
|
|
|
||
|
|
|
||
|
|
class CheckCommandHasChanges(StandardBase):
|
||
|
|
|
||
|
|
sid = "ANSIBLE0011"
|
||
|
|
description = "Commands should be idempotent"
|
||
|
|
helptext = (
|
||
|
|
"commands should only read while using `changed_when` or try to be "
|
||
|
|
"idempotent while using controls like `creates`, `removes` or `when`"
|
||
|
|
)
|
||
|
|
version = "0.1"
|
||
|
|
types = ["playbook", "task"]
|
||
|
|
|
||
|
|
def check(self, candidate, settings):
|
||
|
|
tasks, errors = self.get_normalized_tasks(candidate, settings)
|
||
|
|
commands = ["command", "shell", "raw"]
|
||
|
|
|
||
|
|
if not errors:
|
||
|
|
for task in tasks:
|
||
|
|
if task["action"]["__ansible_module__"] in commands:
|
||
|
|
if (
|
||
|
|
"changed_when" not in task and "when" not in task
|
||
|
|
and "when" not in task.get("__ansible_action_meta__", [])
|
||
|
|
and "creates" not in task["action"] and "removes" not in task["action"]
|
||
|
|
):
|
||
|
|
errors.append(self.Error(task["__line__"], self.helptext))
|
||
|
|
|
||
|
|
return self.Result(candidate.path, errors)
|