github/ansible-later
0
0
Fork 0
mirror of https://github.com/thegeeklab/ansible-later.git synced 2024-11-25 14:20:45 +00:00
Code Issues Projects Releases Wiki Activity

fix: ignore complex changed when checks in rule CheckChangedInWhen (#628)

Browse Source
This commit is contained in:
Robert Kaussow 2023-06-28 15:57:40 +02:00 committed by GitHub
parent a38a9aa11b
commit 26ce453fc4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ansiblelater/rules/CheckChangedInWhen.py
View File

@ -36,7 +36,7 @@ class CheckChangedInWhen(StandardBase):
for task in tasks: for task in tasks:
when = None when = None
if task["__ansible_action_type__"] == "task": if task["__ansible_action_type__"] in ["task", "meta"]:
when = task.get("when") when = task.get("when")
if isinstance(when, str): if isinstance(when, str):
@ -54,6 +54,15 @@ class CheckChangedInWhen(StandardBase):
if not isinstance(item, str): if not isinstance(item, str):
return False return False
if not {"and", "or", "not"}.isdisjoint(item.split()):
return False
return any( return any(
changed in item for changed in [".changed", "|changed", '["changed"]', "['changed']"] changed in item for changed in [
".changed",
"|changed",
'["changed"]',
"['changed']",
"is changed",
]
) )