mirror of
https://github.com/thegeeklab/ansible-later.git
synced 2024-06-26 20:21:01 +02:00
Robert Kaussow
2df48598ec
BREAKING CHANGE: The option to define a `Standards` version has been removed. Every new rule that is added on upcoming releases is activated by default and will also create errors if triggered. The behavior of rules can be controlled by the existing `rules.exclude_filter` or `rules.warning_filter` options. BREAKING CHANGE: The option `rules.buildin` has been renamed to `rules.builtin`. BREAKING CHANGE: The option `rules.standards` has been renamed to `rules.dir`. BREAKING CHANGE: The option `rules.filter` has been renamed to `rules.include_filter`.
26 lines
1.0 KiB
Python
26 lines
1.0 KiB
Python
from ansiblelater.rule import RuleBase
|
|
|
|
|
|
class CheckShellInsteadCommand(RuleBase):
|
|
sid = "ANSIBLE0010"
|
|
description = "Shell should only be used when essential"
|
|
helptext = "shell should only be used when piping, redirecting or chaining commands"
|
|
types = ["playbook", "task", "handler"]
|
|
|
|
def check(self, candidate, settings):
|
|
tasks, errors = self.get_normalized_tasks(candidate, settings)
|
|
|
|
if not errors:
|
|
for task in tasks:
|
|
if task["action"]["__ansible_module__"] == "shell":
|
|
# skip processing if args.executable is used as this
|
|
# parameter is no longer support by command module
|
|
if "executable" in task["action"]:
|
|
continue
|
|
|
|
cmd = self.get_safe_cmd(task)
|
|
if not any(ch in cmd for ch in self.SHELL_PIPE_CHARS):
|
|
errors.append(self.Error(task["__line__"], self.helptext))
|
|
|
|
return self.Result(candidate.path, errors)
|