mirror of
https://github.com/thegeeklab/ansible-later.git
synced 2024-06-26 20:21:01 +02:00
Robert Kaussow
2df48598ec
BREAKING CHANGE: The option to define a `Standards` version has been removed. Every new rule that is added on upcoming releases is activated by default and will also create errors if triggered. The behavior of rules can be controlled by the existing `rules.exclude_filter` or `rules.warning_filter` options. BREAKING CHANGE: The option `rules.buildin` has been renamed to `rules.builtin`. BREAKING CHANGE: The option `rules.standards` has been renamed to `rules.dir`. BREAKING CHANGE: The option `rules.filter` has been renamed to `rules.include_filter`.
26 lines
869 B
Python
26 lines
869 B
Python
from collections import defaultdict
|
|
|
|
from ansiblelater.rule import RuleBase
|
|
|
|
|
|
class CheckUniqueNamedTask(RuleBase):
|
|
sid = "ANSIBLE0003"
|
|
description = "Tasks and handlers must be uniquely named within a single file"
|
|
helptext = "name `{name}` appears multiple times"
|
|
types = ["playbook", "task", "handler"]
|
|
|
|
def check(self, candidate, settings):
|
|
tasks, errors = self.get_normalized_tasks(candidate, settings)
|
|
|
|
namelines = defaultdict(list)
|
|
|
|
if not errors:
|
|
for task in tasks:
|
|
if "name" in task:
|
|
namelines[task["name"]].append(task["__line__"])
|
|
for name, lines in namelines.items():
|
|
if name and len(lines) > 1:
|
|
errors.append(self.Error(lines[-1], self.helptext.format(name=name)))
|
|
|
|
return self.Result(candidate.path, errors)
|