mirror of
https://github.com/thegeeklab/ansible-later.git
synced 2024-06-30 06:01:00 +02:00
Robert Kaussow
2df48598ec
BREAKING CHANGE: The option to define a `Standards` version has been removed. Every new rule that is added on upcoming releases is activated by default and will also create errors if triggered. The behavior of rules can be controlled by the existing `rules.exclude_filter` or `rules.warning_filter` options. BREAKING CHANGE: The option `rules.buildin` has been renamed to `rules.builtin`. BREAKING CHANGE: The option `rules.standards` has been renamed to `rules.dir`. BREAKING CHANGE: The option `rules.filter` has been renamed to `rules.include_filter`.
40 lines
1.6 KiB
Python
40 lines
1.6 KiB
Python
from ansiblelater.rule import RuleBase
|
|
|
|
|
|
class CheckNativeYaml(RuleBase):
|
|
sid = "LINT0008"
|
|
description = "Use YAML format for tasks and handlers rather than key=value"
|
|
helptext = "task arguments appear to be in key value rather than YAML format"
|
|
types = ["playbook", "task", "handler"]
|
|
|
|
def check(self, candidate, settings):
|
|
tasks, errors = self.get_action_tasks(candidate, settings)
|
|
exclude_modules = settings["ansible"]["native-yaml"]["exclude"]
|
|
|
|
if not errors:
|
|
for task in tasks:
|
|
normal_form, error = self.get_normalized_task(task, candidate, settings)
|
|
|
|
if error:
|
|
errors.extend(error)
|
|
break
|
|
|
|
module = normal_form["action"]["__ansible_module__"]
|
|
arguments = [
|
|
bytes(x, "utf-8").decode("utf8", "ignore")
|
|
for x in normal_form["action"]["__ansible_arguments__"]
|
|
]
|
|
|
|
if module in exclude_modules:
|
|
continue
|
|
# Cope with `set_fact` where task["set_fact"] is None
|
|
if not task.get(module):
|
|
continue
|
|
if isinstance(task[module], dict):
|
|
continue
|
|
# strip additional newlines off task[action]
|
|
task_action = bytes(task[module].strip(), "utf-8").decode("utf8", "ignore")
|
|
if list(filter(lambda a: a != "\\", task_action.split())) != arguments:
|
|
errors.append(self.Error(task["__line__"], self.helptext))
|
|
return self.Result(candidate.path, errors)
|