mirror of
https://github.com/thegeeklab/ansible-later.git
synced 2024-06-30 06:01:00 +02:00
Robert Kaussow
2df48598ec
BREAKING CHANGE: The option to define a `Standards` version has been removed. Every new rule that is added on upcoming releases is activated by default and will also create errors if triggered. The behavior of rules can be controlled by the existing `rules.exclude_filter` or `rules.warning_filter` options. BREAKING CHANGE: The option `rules.buildin` has been renamed to `rules.builtin`. BREAKING CHANGE: The option `rules.standards` has been renamed to `rules.dir`. BREAKING CHANGE: The option `rules.filter` has been renamed to `rules.include_filter`.
33 lines
1.2 KiB
Python
33 lines
1.2 KiB
Python
# Copyright (c) 2016, Tsukinowa Inc. <info@tsukinowa.jp>
|
|
# Copyright (c) 2018, Ansible Project
|
|
from ansiblelater.rule import RuleBase
|
|
|
|
|
|
class CheckRelativeRolePaths(RuleBase):
|
|
sid = "ANSIBLE0025"
|
|
description = "Don't use a relative path in a role"
|
|
helptext = "`copy` and `template` modules don't need relative path for `src`"
|
|
types = ["playbook", "task", "handler"]
|
|
|
|
def check(self, candidate, settings):
|
|
tasks, errors = self.get_normalized_tasks(candidate, settings)
|
|
module_to_path_folder = {
|
|
"copy": "files",
|
|
"win_copy": "files",
|
|
"template": "templates",
|
|
"win_template": "win_templates",
|
|
}
|
|
|
|
if not errors:
|
|
for task in tasks:
|
|
module = task["action"]["__ansible_module__"]
|
|
path_to_check = None
|
|
|
|
if module in module_to_path_folder and "src" in task["action"]:
|
|
path_to_check = f"../{module_to_path_folder[module]}"
|
|
|
|
if path_to_check and path_to_check in task["action"]["src"]:
|
|
errors.append(self.Error(task["__line__"], self.helptext))
|
|
|
|
return self.Result(candidate.path, errors)
|