mirror of
https://github.com/thegeeklab/ansible-later.git
synced 2024-11-25 06:10:42 +00:00
Robert Kaussow
2df48598ec
BREAKING CHANGE: The option to define a `Standards` version has been removed. Every new rule that is added on upcoming releases is activated by default and will also create errors if triggered. The behavior of rules can be controlled by the existing `rules.exclude_filter` or `rules.warning_filter` options. BREAKING CHANGE: The option `rules.buildin` has been renamed to `rules.builtin`. BREAKING CHANGE: The option `rules.standards` has been renamed to `rules.dir`. BREAKING CHANGE: The option `rules.filter` has been renamed to `rules.include_filter`.
29 lines
1.1 KiB
Python
29 lines
1.1 KiB
Python
from ansiblelater.rule import RuleBase
|
|
|
|
|
|
class CheckCommandHasChanges(RuleBase):
|
|
sid = "ANSIBLE0011"
|
|
description = "Commands should be idempotent"
|
|
helptext = (
|
|
"commands should only read while using `changed_when` or try to be "
|
|
"idempotent while using controls like `creates`, `removes` or `when`"
|
|
)
|
|
types = ["playbook", "task"]
|
|
|
|
def check(self, candidate, settings):
|
|
tasks, errors = self.get_normalized_tasks(candidate, settings)
|
|
commands = ["command", "shell", "raw"]
|
|
|
|
if not errors:
|
|
for task in tasks:
|
|
if task["action"]["__ansible_module__"] in commands and (
|
|
"changed_when" not in task
|
|
and "when" not in task
|
|
and "when" not in task.get("__ansible_action_meta__", [])
|
|
and "creates" not in task["action"]
|
|
and "removes" not in task["action"]
|
|
):
|
|
errors.append(self.Error(task["__line__"], self.helptext))
|
|
|
|
return self.Result(candidate.path, errors)
|