mirror of
https://github.com/thegeeklab/ansible-later.git
synced 2024-11-25 06:10:42 +00:00
Robert Kaussow
2df48598ec
BREAKING CHANGE: The option to define a `Standards` version has been removed. Every new rule that is added on upcoming releases is activated by default and will also create errors if triggered. The behavior of rules can be controlled by the existing `rules.exclude_filter` or `rules.warning_filter` options. BREAKING CHANGE: The option `rules.buildin` has been renamed to `rules.builtin`. BREAKING CHANGE: The option `rules.standards` has been renamed to `rules.dir`. BREAKING CHANGE: The option `rules.filter` has been renamed to `rules.include_filter`.
27 lines
850 B
Python
27 lines
850 B
Python
from ansiblelater.rule import RuleBase
|
|
|
|
|
|
class CheckWhenFormat(RuleBase):
|
|
sid = "ANSIBLE0022"
|
|
description = "Don't use Jinja2 in when"
|
|
helptext = (
|
|
"`when` is a raw Jinja2 expression, redundant {{ }} " "should be removed from variable(s)"
|
|
)
|
|
types = ["playbook", "task", "handler"]
|
|
|
|
def check(self, candidate, settings):
|
|
tasks, errors = self.get_normalized_tasks(candidate, settings)
|
|
|
|
if not errors:
|
|
for task in tasks:
|
|
if "when" in task and not self._is_valid(task["when"]):
|
|
errors.append(self.Error(task["__line__"], self.helptext))
|
|
|
|
return self.Result(candidate.path, errors)
|
|
|
|
@staticmethod
|
|
def _is_valid(when):
|
|
if not isinstance(when, str):
|
|
return True
|
|
return when.find("{{") == -1 and when.find("}}") == -1
|