mirror of
https://github.com/thegeeklab/ansible-later.git
synced 2024-11-24 22:00:40 +00:00
Robert Kaussow
2df48598ec
BREAKING CHANGE: The option to define a `Standards` version has been removed. Every new rule that is added on upcoming releases is activated by default and will also create errors if triggered. The behavior of rules can be controlled by the existing `rules.exclude_filter` or `rules.warning_filter` options. BREAKING CHANGE: The option `rules.buildin` has been renamed to `rules.builtin`. BREAKING CHANGE: The option `rules.standards` has been renamed to `rules.dir`. BREAKING CHANGE: The option `rules.filter` has been renamed to `rules.include_filter`.
36 lines
1.2 KiB
Python
36 lines
1.2 KiB
Python
import re
|
|
|
|
from ansiblelater.candidate import Template
|
|
from ansiblelater.rule import RuleBase
|
|
|
|
|
|
class CheckCompareToLiteralBool(RuleBase):
|
|
sid = "ANSIBLE0013"
|
|
description = "Don't compare to True or False"
|
|
helptext = "use `when: var` rather than `when: var == True` (or conversely `when: not var`)"
|
|
types = ["playbook", "task", "handler"]
|
|
|
|
def check(self, candidate, settings):
|
|
yamllines, errors = self.get_normalized_yaml(candidate, settings)
|
|
|
|
if not errors:
|
|
if isinstance(candidate, Template):
|
|
matches = []
|
|
jinja_string = re.compile("({{|{%)(.*?)(}}|%})")
|
|
|
|
for i, line in yamllines:
|
|
match = jinja_string.findall(line)
|
|
if match:
|
|
for item in match:
|
|
matches.append((i, item[1]))
|
|
|
|
yamllines = matches
|
|
|
|
literal_bool_compare = re.compile("[=!]= ?(True|true|False|false)")
|
|
|
|
for i, line in yamllines:
|
|
if literal_bool_compare.findall(line):
|
|
errors.append(self.Error(i, self.helptext))
|
|
|
|
return self.Result(candidate.path, errors)
|