ansible-later/docs/content/build_rules/standards_check.md
Robert Kaussow 43d7edca32
refactor plugin system to use a class-based approach (#68)
* refactor plugin system to use a class-based approach

* disable some docstring linter errors and fix imports

* cleanup

* fix docs

* add metavars to cli arguments for better helptext

* add option to disable buildin rules

* remove print

* remove dead code
2021-01-30 16:52:48 +01:00

1.3 KiB

title
Minimal standard checks

A typical standards check will look like:

{{< highlight Python "linenos=table" >}} class CheckBecomeUser(StandardBase):

sid = "ANSIBLE0015"
description = "Become should be combined with become_user"
helptext = "the task has `become` enabled but `become_user` is missing"
version = "0.1"
types = ["playbook", "task", "handler"]

def check(self, candidate, settings):
    tasks, errors = self.get_normalized_tasks(candidate, settings)
    true_value = [True, "true", "True", "TRUE", "yes", "Yes", "YES"]

    if not errors:
        gen = (task for task in tasks if "become" in task)
        for task in gen:
            if task["become"] in true_value and "become_user" not in task.keys():
                errors.append(self.Error(task["__line__"], self.helptext))

    return self.Result(candidate.path, errors)

{{< /highlight >}}

They return a Result object, which contains a possibly empty list of Error objects. Error objects are formed of a line number and a message. If the error applies to the whole file being reviewed, set the line number to None.